Submission Details
Severity:
Avoid accessing state when the same variable is available in memory
Summary
Within the borrow function from Lender.sol, _updatePoolBalance is called using the following arguments: poolId, pools[poolId].poolBalance - debt. There is no need to access the state through pools[poolId].poolBalance given that on line 238 we cache the pools[poolId] inside the pool variable.
The _updatePoolBalance should be called with the following arguments: poolId, pool.poolBalance - debt.
This is especially important given that this happens within a for loop.
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628
USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.