Submission Details
Severity:
Modifier gas optimization for onlyOwner modifier
Summary
It is recommended to move the modifiers require statements into an internal virtual function. Moreover, the require statement should be replaced with if check + custom error. This reduces the size of compiled contracts that use the modifiers. Putting the check in an internal function decreases contract size when a modifier is used multiple times. The best way of implementing this is presented in OZ's Ownable.sol (Link 2):
- modifier onlyOwner() virtual {
- require(msg.sender == owner, "UNAUTHORIZED");
- _;
- }
+modifier onlyOwner() {
+ _checkOwner();
+ _;
+ }
+function _checkOwner() internal view virtual {
+ if (owner() != _msgSender()) {
+ revert OwnableUnauthorizedAccount(_msgSender());
+ }
+ }
In Errors.sol:
+error OwnableUnauthorizedAccount(address sender);
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.