Unchecked trasnfer/trasnferFrom may lead to silent returns
Summary
Not using the safe version of transfer and transferFrom may lead to loss of funds, due to silent fails.
Vulnerability Details
Some tokens comply to the ERC20 interface and others don't. Because of this it's best to always check the return of transfer or trasnferFrom or even better, to use the safe version.
Example scenario is if we use USDT - it returns false on failed transfers, and does not revert. So any not checked transfer could fail silently and the code in Bleedle to continue executing without the funds being sent.
Impact
Loss of funds for the system and the users.
Tools Used
Manual review
Recommendations
Use safeTransfer and safeTransferFrom from SafeERC20.sol
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.