Summary

the loan auction length has not been updated in the functions giveLoan and buyLoan

Vulnerability Details

no update for the auction length in the functions giveLoan and buyLoan , can result in shorter auction length for the loan than the pool auction (eg. if the loan.auctionLength = 1 days and the Pool.auctionLength = 2 days the actual auction length will be 1 day as the old pool auction length) , and this may result in liquidate the borrower and loss his collateral to the lender in the function seizeLoan or miss a chance to get a new lender form the function buyLoan

Impact

not updating the loan.auctionLength will result in the borrowers lose there collateral or can give the borrower an auction length bigger than the pool auction length loss in the value of the collateral that the lender will take after the leauidation .

Tools Used

manual review

Recommendations

update the loan.auctionLength to the pool.auctionLength inside the giveLoan and buyLoan functions