Beedle - Oracle free perpetual lending

Summary

Staking contract is Ownable but does not use the Ownable functionality

Vulnerability Details

Staking.sol line 11 inherits Ownable for access control but never uses it. There are no onlyOwner functions in the contract. There is nothing that indicates need for access control, rights, ownerships etc

Impact

Informational + Gas to Potential Low: Informational in that it impacts code quality, maintainability. Gas in that it makes the Staking.sol contract bigger than necessary as all functionality of Ownable is added into it increasing its size which leads to more expensive deployments costs etc. Potential Low in that it may be indicative of missing logic that was planned for but was not added to the code.

Tools Used

Manual Analysis

Recommendations

It is recommended that if this was done in error to remove else to consider what intended functionality may have been missed