Beedle - Oracle free perpetual lending

Summary

There are several functionalities and actions that take address and do not check that address is not zero address

Vulnerability Details

1. Lender.sol line 100 //lacks zero address check on _feeReceiver
   function setFeeReceiver(address _feeReceiver) external onlyOwner {
   feeReceiver = _feeReceiver;
   }

2. Staking.sol line 80
   function updateFor(address recipient) public { // no check recipient is zero address

Impact

Medium:
Point 1 above leads to fees for the protocol being lost and protocol and Staking not working as expected as there are no fees
Point 2 above leads to wasted gas for public caller

Tools Used

Manual Analysis

Recommendations

It is recommended to ensure necessary functions check that addresses are not Zero Addresses
e.g if(_feeReceiver == address(0) revert MustNotBeZeroAddress(); // etc