Submission Details
Severity:
Spelling/Errors Organization
Summary
Structs.sol
Line #75
- /// @notice the virtual balance based on the multipier
+ /// @notice the virtual balance based on the multiplier
Perhaps a suggestion to order the Errors.sol in the utils folder alphabetically. After searching I could not find a best practice. I do understand however, grouping them together via functional relationship. To me however, alphabetically is easier to read and a sorted list can make version control diffs cleaner when adding or removing errors in the future. You could similarly alphabetized the Structs.sol file.
As is:
// SPDX-License-Identifier: MIT
error PoolConfig();
error LoanTooSmall();
error LoanTooLarge();
error RatioTooHigh();
error FeeTooHigh();
error TokenMismatch();
error Unauthorized();
error AuctionStarted();
error AuctionNotStarted();
error AuctionEnded();
error AuctionNotEnded();
error RateTooHigh();
error PoolTooSmall();
error ZeroCollateral();
error AuctionTooShort();
Alphabetical:
// SPDX-License-Identifier: MIT
error AuctionEnded();
error AuctionNotEnded();
error AuctionNotStarted();
error AuctionStarted();
error AuctionTooShort();
error FeeTooHigh();
error LoanTooLarge();
error LoanTooSmall();
error PoolConfig();
error PoolTooSmall();
error RateTooHigh();
error RatioTooHigh();
error TokenMismatch();
error Unauthorized();
error ZeroCollateral();
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.