Submission Details
Severity:
Update balance twice in refinance() function on Lender.sol
Summary
Update balance twice in refinance() function on Lender.sol
Vulnerability Details
Update balance twice in refinance() function on Lender.sol
https://github.com/Cyfrin/2023-07-beedle/blob/main/src/Lender.sol#L636
...
_updatePoolBalance(poolId, pools[poolId].poolBalance - debt);
...
https://github.com/Cyfrin/2023-07-beedle/blob/main/src/Lender.sol#L698
...
pools[poolId].poolBalance -= debt;
...
Impact
It will make Lender.sol contract confusing in balance and new pool owner will be in danger pretty much.
Tools Used
Manual
Recommendations
Need to remove line 698 in Lender.sol contract.
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.