Beedle - Oracle free perpetual lending

Summary

There is no checks that array being used in loop consecutively have the same lengths

Vulnerability Details

Lender.sol line 355 function giveLoan(..) array inputs uint256[] calldata loanIds and bytes32[] calldata poolIds are used simultaneously in for loop but are not checked that they have same length

Impact

Low: If the lengths are different because of lack of this sanity check, the function may revert as one of the arrays may reach out of bounds before the other

Tools Used

Manual Analysis

Recommendations

It is recommended that Lender.sol line 355 function giveLoan(..) check that array lengths are equal as in below
if(loanIds.length != poolIds.length) revert Appropriate_Error;