20,000 USDC
View results
Submission Details
Severity: high
Valid

Slippage parameter is not specified correclty in the `Fees::sellProfits()` function

Summary

The swap in Fees::sellProfit() is executed without specify the correct amountOutMinimum value, opening up to a loss of funds via front running sandwich or another type of price manipulation.

Vulnerability Details

The Fees::sellProfit() function helps to make a swap using an Uniswap Router.

The problem is that the slippage amountOutMinimum parameter is zero, that is extremely dangeraus because the amountOutMInimum = 0 means that the caller accept zero as the minimum amount out tokens from the swap.

Impact

Loss of funds via front running sandwich or another type of price manipulation.

Tools used

Manual review

Recommendations

Follow the Uniswap recommendation by calculating the correct price using an onchain oracle.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.