Submission Details
Severity:
New pool is double accounted when borrower refinances a loan
Summary
New pool is double accounted when borrower refinances a loan.
Vulnerability Details
When borrower refinances loans, tokens are deducted from the new pool:
// now lets deduct our tokens from the new pool
_updatePoolBalance(poolId, pools[poolId].poolBalance - debt);
However, at the end of the refinancing, new pool balance is updated again:
// update pool balance
pools[poolId].poolBalance -= debt;
Impact
New pool lender suffers a loss.
Tools Used
Mannual Review
Recommendations
New pool balance should only be deducted once.
function refinance(Refinance[] calldata refinances) public {
for (uint256 i = 0; i < refinances.length; i++) {
...
- pools[poolId].poolBalance -= debt;
...
}
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628
USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.