Submission Details
Severity:
Use Custom Errors
Summary
Instead of using require, to reduce deployment and runtime cost, you should use Custom Errors. This would save both deployment and runtime cost.
Vulnerability Details
When a revert condition is met in Fees.sol sellProfits() function, the runtime gas cost will be higher with normal compared to custom errors.
Impact
Increase in both deploy and runtime gas costs.
Tools Used
Manual review
Recommendations
+error Unauthorized();
-require(_profits != WETH, "not allowed");
+if(_profits != WETH) revert Unauthorized();
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628
USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.