Beedle - Oracle free perpetual lending

Summary

The "Fees.sol" smart contract contains a critical vulnerability that allows an attacker to perform a sandwich attack during the "sellProfits" function execution. The contract performs a swap using the Uniswap router, and the lack of specifying the "amountOutMinimum" parameter leaves it susceptible to manipulation.

Vulnerability Details

The vulnerability is present in the "Fees.sol" smart contract, specifically within the "sellProfits(address _profits)" function. This function executes a swap with the Uniswap router to convert profits into another token. However, the contract does not specify the "amountOutMinimum" parameter, making it vulnerable to a sandwich attack.

Impact

This vulnerability poses a critical security risk to the contract and its users. An attacker can manipulate the swap execution during the "sellProfits" function call, resulting in losses for legitimate users and potential exploitation of funds.

Recommendations

To address this critical vulnerability and enhance the security of the "Fees.sol" smart contract, the following steps are recommended:

Specify "amountOutMinimum" Parameter: When performing swaps with the Uniswap router, ensure that the "amountOutMinimum" parameter is specified, accounting for a slippage tolerance. This will safeguard against sandwich attacks and prevent the manipulation of swap executions even in volatile market conditions.

Consider Using TWAP Oracle: Implement a Time-Weighted Average Price (TWAP) oracle using the Oracle Library of Uniswap V3. TWAP oracles provide a more robust and accurate representation of asset prices, considering fluctuations over a period of time. Be sure to adjust for slippage tolerance when using the TWAP oracle.

Account for Pool Uniswap Fees: Take into account the fees charged by the Uniswap pool during swaps. These fees can affect the final amount received and should be factored into the "amountOutMinimum" parameter to ensure accurate and secure swap executions.

Explore Chainlink Oracle Integration: Where feasible, consider integrating with a trusted oracle provider like Chainlink. Chainlink's oracles offer a secure and decentralized solution for obtaining reliable price data, and they can also provide information on fees from decentralized exchanges.

By implementing these recommendations, you can significantly improve the security and reliability of the "Fees.sol" smart contract and mitigate the risks associated with the identified vulnerability.