Submission Details
Severity:
No check if `price>0` in `latestRoundData()`
Summary
chain;ink pricefeed can result price as zero in some conditions and here in the implementation there is no check if price is greater than zero or not causing inappropriate result
Vulnerability Details
see summary
https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/blob/main/src/libraries/OracleLib.sol#L21C4-L34C1
Impact
price can be zero and so getAccountCollateralValue and getUsdValue will result zero breaking dscEngine at many places
Tools Used
Manual
Recommendations
add a check if price from latestRoundZero is greater than zero , revert otherwise
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.