Submission Details
Severity:
nonReentrant modifier should come first
Summary
The nonReentrant modifier should occur before all other modifiers
Vulnerability Details
In DSCEngine.sol, the following is used
function redeemCollateral(address tokenCollateralAddress, uint256 amountCollateral)
public
moreThanZero(amountCollateral)
nonReentrant
{
_redeemCollateral(msg.sender, msg.sender, tokenCollateralAddress, amountCollateral);
_revertIfHealthFactorIsBroken(msg.sender);
}
Impact
The other modifiers could be re-entered if they have complex logic
Tools Used
Manual review
Recommendations
change the function to this.
function redeemCollateral(address tokenCollateralAddress, uint256 amountCollateral)
public
nonReentrant
moreThanZero(amountCollateral)
{
_redeemCollateral(msg.sender, msg.sender, tokenCollateralAddress, amountCollateral);
_revertIfHealthFactorIsBroken(msg.sender);
}
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.