Submission Details
Severity:
Constants should be defined rather than using magic numbers
Summary
Constants should be defined rather than using magic numbers
Vulnerability Details
Even assembly
can benefit from using readable constants instead of hex/numeric literals
Instances (1):
File: src/DSCEngine.sol
333: return (collateralAdjustedForThreshold * 1e18) / totalDscMinted;
Link to code - https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/tree/main/src/DSCEngine.sol
Tools Used
Code Review using VSCode
Recommendations
Define constants instead of magic numbers
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.