Summary

function getAccountCollateralValue has a named return, this meand that you can avoid having the return, removig extra opcodes inside the function.

Vulnerability Details

function getAccountCollateralValue(address user) public view returns (uint256 totalCollateralValueInUsd) {
    // loop through each collateral token, get the amount they have deposited, and map it to
    // the price, to get the USD value
    for (uint256 i = 0; i < s_collateralTokens.length; i++) {
        address token = s_collateralTokens[i];
        uint256 amount = s_collateralDeposited[user][token];
        totalCollateralValueInUsd += getUsdValue(token, amount);
    }
    return totalCollateralValueInUsd;
}

Impact

Tools Used

Recommendations

remove return totalCollateralValueInUsd;