15,000 USDC
View results
Submission Details
Severity: low
Valid

Missing 0 address check

Summary

DSCEngine.constructor() has no 0 address checks in its arguments

Vulnerability Details

src/DSCEngine.sol:
111 //////////////////
112: constructor(address[] memory tokenAddresses, address[] memory priceFeedAddresses, address dscAddress) {
113: // USD Price Feeds
114: if (tokenAddresses.length != priceFeedAddresses.length) {
115: revert DSCEngine__TokenAddressesAndPriceFeedAddressesMustBeSameLength();
116: }
117: // For example ETH / USD, BTC / USD, MKR / USD, etc
118: for (uint256 i = 0; i < tokenAddresses.length; i++) {
119: s_priceFeeds[tokenAddresses[i]] = priceFeedAddresses[i];
120: s_collateralTokens.push(tokenAddresses[i]);
121: }
122: i_dsc = DecentralizedStableCoin(dscAddress);
123: }

Impact

Tools Used

Manuel Code Review

Recommendations

add 0 address check in constructor

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.