Submission Details
Severity:
Redundant balance check in burn method of DecentralizedStableCoin contract
Summary
The burn method in DecentralizedStableCoin contract reads the user's balance from the storage and reverts with custom error if the amount of DSC to burn exceeds it.
function burn(uint256 _amount) public override onlyOwner {
uint256 balance = balanceOf(msg.sender);
if (_amount <= 0) {
revert DecentralizedStableCoin__MustBeMoreThanZero();
}
if (balance < _amount) {
revert DecentralizedStableCoin__BurnAmountExceedsBalance();
}
super.burn(_amount);
}
This check is already being performed in the _burn method of ERC20 contract. The method can therefore be simplified for gas savings:
function burn(uint256 _amount) public override onlyOwner {
if (_amount <= 0) {
revert DecentralizedStableCoin__MustBeMoreThanZero();
}
super.burn(_amount);
}
The custom error DecentralizedStableCoin__BurnAmountExceedsBalance can be removed.
Vulnerability Details
n/a
Impact
Unnecessary gas consumption
Tools Used
Manual review
Recommendations
Please consider removing redundant lines of code as suggested in summary.
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.