Submission Details
Severity:
[I-7] Lines are too long
Summary
Usually lines in source code are limited to 80 characters. Today's screens are much larger so it's reasonable to stretch this in some cases. The solidity style guide recommends a maximumum line length of 120 characters, so the lines below should be split when they reach that length.
Vulnerability Details
Instances (6):
File: src/DSCEngine.sol
44: * Our DSC system should always be "overcollateralized". At no point, should the value of all collateral <= the $ backed value of all the DSC.
46: * @notice This contract is the core of the DSC System. It handles all the logic for mining and redeeming DSC, as well as depositing & withdrawing collateral.
157: bool success = IERC20(tokenCollateralAddress).transferFrom(msg.sender, address(this), amountCollateral); // @audit fee-on-transfer, safeTransferFrom
223: * @notice This function working assumes the protocol will be roughly 200% overcollateralized in order for this to work.
224: * @notice A known bug would be if the protocol were 100% or less collateralized, then we wouldn't be able to incentive the liquidators.
File: src/DecentralizedStableCoin.sol
36: * This is the contract meant to be governed by DSCEngine. This contract is just the ERC20 implementation of our stablecoin system.
Impact
Tools Used
Recommendations
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.