Submission Details
Severity:
Constructors can be marked `payable`
Summary
Payable functions cost less gas to execute
Vulnerability Details
Since the compiler does not have to add extra checks to ensure that a payment wasn't provided, payable functions cost less gas. A constructor can safely be marked as payable, since only the deployer would be able to pass funds, and the project itself would not pass any funds.
112 constructor(address[] memory tokenAddresses, address[] memory priceFeedAddresses, address dscAddress) {
https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/blob/main/src/DSCEngine.sol#L112
Impact
Save 21 gas
Tools Used
Manual review
Recommendations
Set constructor as payable
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664
USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.