Submission Details
Severity:
Array does not have a pop function
Summary
Arrays without the pop operation increase the likelihood of out-of-gas errors.
Vulnerability Details
Arrays without the pop operation increase the likelihood of out-of-gas errors.
120 s_collateralTokens.push(tokenAddresses[i]);
https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/blob/main/src/DSCEngine.sol#L120
Impact
It could happen that array grows large enough to trigger out of gas errors while dealing with it
Tools Used
Manual review
Recommendations
Add functionality that could remove items from the array
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.