Some functions that return values make use of named return variables and others do not
OracleLib.sol does not use named return variables
DSCEngine.sol line 300 uses a named return variables -> returns (uint256 totalDscMinted, uint256 collateralValueInUsd)
DSCEngine.sol line 350 uses a named return variables -> returns (uint256 totalCollateralValueInUsd)
DSCEngine.sol line 372 uses a named return variables -> returns (uint256 totalDscMinted, uint256 collateralValueInUsd)
DSCEngine.sol remaining functions does not use named return variables
DecentralizedStableCoin.sol does not use named return variables
There is no consistency, sound basis or explanation as to why the functions that make use of named return variables do so.
Informational: This leads to code quality issues, readability and maintainability issues. Consider case where functions have named return variables but a return is still used ignoring the return variables because developer expected all functions in code don't use named return variables etc
Manual Analysis
It is recommended
To be consistent with use of named return variables and apply to all functions or not apply at all
If applied to some functions it may be necessary to document why e.g all getter functions use named return variables etc
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.