Submission Details
Severity:
Large transfers may not work with some ERC20 tokens
Summary
Some IERC20 implementations (e.g UNI, COMP) may fail if the valued transferred is larger than uint96. Source.
Vulnerability Details
bool success = IERC20(tokenCollateralAddress).transferFrom(msg.sender, address(this), amountCollateral);
https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/blob/main/src/DSCEngine.sol#L157
bool success = IERC20(tokenCollateralAddress).transfer(to, amountCollateral);
https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/blob/main/src/DSCEngine.sol#L287
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.