Submission Details
Severity:
Gas saving recommendations
Summary
Inline code rather than modifier is supposed to save gas.
a += bcosts more gas thana = a + b.
So we can optimize gas costs by implementing them.
Vulnerability Details
Use inline code instead of modifier when the modifier is used only once. This can save gas.
Impact
Gas saving
Tools Used
Manual review
Recommendations
- modifier isAllowedToken(address token) {
- // @audit gas write this in line to save gas. This is only used once. gas saved is about 100. 34505 vs 34512
- if (s_priceFeeds[token] == address(0)) {
- revert DSCEngine__NotAllowedToken();
- }
- _;
- }
...
function depositCollateral(address tokenCollateralAddress, uint256 amountCollateral)
public
moreThanZero(amountCollateral)
isAllowedToken(tokenCollateralAddress)
nonReentrant
{
+ if (s_priceFeeds[token] == address(0)) {
+ revert DSCEngine__NotAllowedToken();
+ }
- s_collateralDeposited[msg.sender][tokenCollateralAddress] += amountCollateral; // @audit use normal calculation instead of this +=
+ s_collateralDeposited[msg.sender][tokenCollateralAddress] = s_collateralDeposited[msg.sender][tokenCollateralAddress] + amountCollateral;
emit CollateralDeposited(msg.sender, tokenCollateralAddress, amountCollateral);
bool success = IERC20(tokenCollateralAddress).transferFrom(msg.sender, address(this), amountCollateral); // @audit-info known issue: should use safeTransferFrom
if (!success) {
revert DSCEngine__TransferFailed(tokenCollateralAddress);
}
}
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.