Submission Details
Severity:
Constants should be be used for hardcoded values
Description
Constants should be be used for hardcoded values, especially if the constants already exist, as it is in this case in DSCEngine.
uint256 private constant PRECISION = 1e18;
In DSCEngine::_calculateHealthFactor the 1e18 can be safely (and contextually) replaced with the already declared PRECISION constant.
return (collateralAdjustedForThreshold * 1e18) / totalDscMinted;
Recommend Mitigation
Use the PRECISION constant instead of 1e18.
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.