Submission Details
Severity:
Some protocol unit tests are incorrect or provide no value
Description
The following tests actually do not provide any value:
DSCEngineTest.t::testCanDepositCollateralWithoutMinting
function testCanDepositCollateralWithoutMinting() public depositedCollateral {
uint256 userBalance = dsc.balanceOf(user);
assertEq(userBalance, 0);
}
DSCEngineTest.t::testCanMintWithDepositedCollateral
function testCanMintWithDepositedCollateral() public depositedCollateralAndMintedDsc {
uint256 userBalance = dsc.balanceOf(user);
assertEq(userBalance, amountToMint);
}
DSCEngineTest.t::testLiquidatorTakesOnUsersDebt
function testLiquidatorTakesOnUsersDebt() public liquidated {
(uint256 liquidatorDscMinted,) = dsce.getAccountInformation(liquidator);
assertEq(liquidatorDscMinted, amountToMint);
}
DSCEngineTest.t::testUserHasNoMoreDebt
function testUserHasNoMoreDebt() public liquidated {
(uint256 userDscMinted,) = dsce.getAccountInformation(user);
assertEq(userDscMinted, 0);
}
Recommend Mitigation
Implemented intended testing logic if applicable or remove the tests.
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.