The NatSpec comments says mintDsc
and depositCollateral
@notice follows CEI
but they don't.
The mintDsc
and depositCollateral
doesn't have any check apart from the moreThanZero
modifier and doesn't follow the CEI pattern.
The depositCollateral
doesn't have any check apart from the moreThanZero
and isAllowedToken
modifiers and doesn't follow the CEI pattern.
Unclear doc / code.
Manual review
Either modify the NatSpec to remove the @notice follows CEI, or refactor the functions to follow the CEI pattern and add checks (in which case you can also remove the nonReentrant modifiers).
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.