Foundry DeFi Stablecoin CodeHawks Audit Contest

Summary

The NatSpec comments says mintDsc and depositCollateral @notice follows CEI but they don't.

Vulnerability Details

The mintDsc and depositCollateral doesn't have any check apart from the moreThanZero modifier and doesn't follow the CEI pattern.
The depositCollateral doesn't have any check apart from the moreThanZero and isAllowedToken modifiers and doesn't follow the CEI pattern.

Impact

Unclear doc / code.

Tools Used

Manual review

Recommendations

Either modify the NatSpec to remove the @notice follows CEI, or refactor the functions to follow the CEI pattern and add checks (in which case you can also remove the nonReentrant modifiers).