15,000 USDC
View results
Submission Details
Severity: medium
Valid

Gas used for unnecessary checks

Summary

Unnecessary nonReentrant modifier
mintDsc function calls our DSC token contract and may not cause reentrancy vulnarability

Unnecessary healFactor check of user
liquidate function checks endingUserHealthFactor <= startingUserHealthFactor, but no way ending health factor can not be higher then starting

Unnecessary healFactor check of liquidator
liquidate function checks _revertIfHealthFactorIsBroken(msg.sender) of liquidator, but their health factor won't ever be broken, as they just burn DSC

Impact

Extra gas usage

Tools Used

Observation

Recommendations

Delete unnecessary checks

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.