Submission Details
Severity:
Modifier gas optimization
Summary
It is recommended to move the if + custom error checks from a modifier into an internal virtual function. This reduces the size of compiled contracts that use the modifiers. Putting the check in an internal function decreases contract size when a modifier is used multiple times.
Recommendations
modifier moreThanZero(uint256 amount) {
- if (amount == 0) {
- revert DSCEngine__NeedsMoreThanZero();
- }
+ moreThanZeroCheck(amount);
_;
}
modifier isAllowedToken(address token) {
- if (s_priceFeeds[token] == address(0)) {
- revert DSCEngine__NotAllowedToken();
- }
+ isAllowedTokenCheck(token);
_;
}
+ function moreThanZeroCheck(uint256 amount) internal virtual {
+ if (amount == 0) {
+ revert DSCEngine__NeedsMoreThanZero();
+ }
+ }
+ function isAllowedTokenCheck(address token) internal virtual {
+ if (s_priceFeeds[token] == address(0)) {
+ revert DSCEngine__NotAllowedToken();
+ }
+ }
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.