Submission Details
Severity:
Tautology check for address(0) in `mint` function
Summary
In contract DecentralizedStableCoin.sol, tautology expression has been detected. Such
expression is of no use since it is already being evaluated in ERC20 abstract contract
ERC20.sol#L283
Vulnerability Details
Mint function in DecentralizedStableCoin.sol
function mint(address _to, uint256 _amount) external onlyOwner returns (bool) {
if (_to == address(0)) {
revert DecentralizedStableCoin__NotZeroAddress();
}
if (_amount <= 0) {
revert DecentralizedStableCoin__MustBeMoreThanZero();
}
_mint(_to, _amount);
return true;
}
Inherited _mint function in ERC20 abstract contract
function _mint(address account, uint256 value) internal {
if (account == address(0)) {
revert ERC20InvalidReceiver(address(0));
}
_update(address(0), account, value);
}
Tools Used
Manual Review
Recommendations
Remove the following lines in DecentralizedStableCoin.sol#L58-L59
if (_to == address(0)) {
revert DecentralizedStableCoin__NotZeroAddress();
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.