Submission Details
Severity:
Constants in comparisons should appear on the left side
Summary
Constants in comparisons should appear on the left side
Vulnerability Details
Doing so will prevent typo bugs
Instances (5):
File: src/DSCEngine.sol
96: if (amount == 0) {
331: if (totalDscMinted == 0) return type(uint256).max;
Link to code - https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/tree/main/src/DSCEngine.sol
File: src/DecentralizedStableCoin.sol
49: if (_amount <= 0) {
59: if (_to == address(0)) {
63: if (_amount <= 0) {
Link to code - https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/tree/main/src/DecentralizedStableCoin.sol
Tools Used
Manual inspection
Recommendations
Consider placing constants on the left side in comparisons
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.