Submission Details
Severity:
The `nonReentrant` `modifier` should occur before all other modifiers
Summary
The nonReentrant modifier should occur before all other modifiers
Vulnerability Details
This is a best-practice to protect against reentrancy in other modifiers
Instances (4):
File: src/DSCEngine.sol
154: nonReentrant
187: nonReentrant
198: function mintDsc(uint256 amountDscToMint) public moreThanZero(amountDscToMint) nonReentrant {
233: nonReentrant
Link to code - https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/tree/main/src/DSCEngine.sol
Tools Used
Manual inspection
Recommendations
Consider placing the nonReentrant modifier as the first modifier.
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.