Submission Details
Severity:
Remove useless `_revertIfHealthFactorIsBroken` check to save gas
Summary
The _revertIfHealthFactorIsBroken() check in the liquidate() function is useless and can be removed to save gas.
Vulnerability Details
The _revertIfHealthFactorIsBroken() check is useless because the if above is insuring that HealthFactor has improved or it reverts.
uint256 endingUserHealthFactor = _healthFactor(user);
if (endingUserHealthFactor <= startingUserHealthFactor) {
revert DSCEngine__HealthFactorNotImproved();
}
Impact
Useless gas consumption.
Tools Used
Manual review.
Recommendations
Remove the _revertIfHealthFactorIsBroken()check in the liquidate() function
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.