Summary

The constructor does not check and process duplicate addresses, so if there are duplicate addresses, it may result in data overwriting or fewer addresses in the array than expected.

Vulnerability Details

The system only checks whether the number of addresses in the two arrays is equal, ignoring the processing of duplicate addresses. The code does not check and process for duplicate addresses in the array of tokenAddresses passed in. If duplicate addresses are added to the s_priceFeeds map or s_collateralTokens array, it may result in data overwriting or fewer addresses in the array than expected.

Impact

May result in data overwriting or fewer addresses in the array than expected. This leads to miscalculation of funds.

Tools Used

Recommendations

Add duplicate address processing.