Submission Details
Severity:
[G-01] No need return all values staleCheckLatestRoundData function
Summary
In our libary OracleLib.sol, staleCheckLatestRoundData function returns 5 values, of which only 1 is used.
Vulnerability Details
The function returns roundId, answer, startedAt, updatedAt, answeredInRound but only answer is used in
Impact
Gas optimization
Tools Used
Manual code review
Recommendations
Change that the staleCheckLatestRoundData function only returns the answer(price) and make the necessary changes in the affected functions such as:
DSCEnginel.sol/getTokenAmountFromUsd
- (, int256 price,,,) = priceFeed.staleCheckLatestRoundData();
+ int256 price = priceFeed.staleCheckLatestRoundData()
DSCEnginel.sol/getUsdValue
- (, int256 price,,,) = priceFeed.staleCheckLatestRoundData();
+ int256 price = priceFeed.staleCheckLatestRoundData()
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.