Submission Details
Severity:
[L-02] It is not specified which token is not allowed
Summary
The error DSCEngine__NotAllowedToken() should include the address of the disallowed token, to make it easier for the user or dev to see what token is throwing the error.
Vulnerability Details
The use of errors should describe the situation that presents the error, in this case the error DSCEngine__NotAllowedToken() error does not include the address of the token that is not allowed, even when the modifier that uses it is passed this address by parameter.
Impact
Low
Tools Used
Manual code review
Recommendations
Change for :
- `error DSCEngine__NotAllowedToken()`
+ `error DSCEngine__NotAllowedToken(address token)`
and
modifier isAllowedToken(address token) {
if (s_priceFeeds[token] == address(0)) {
- revert DSCEngine__NotAllowedToken();
+ revert DSCEngine__NotAllowedToken(token);
}
_;
}
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.