Submission Details
Severity:
<X> += <Y> COSTS MORE GAS THAN <X> = <X> + <Y> FOR STATE VARIABLES or ( -= )
Summary
[G-5] += COSTS MORE GAS THAN = + FOR STATE VARIABLES or ( -= )
AVOID COMPOUND ASSIGNMENT OPERATOR IN STATE VARIABLES
Using compound assignment operators for state variables (like State += X or State -= X ) its more expensive than using operator assignment (like State = State + X or State = State - X ).
file: /src/DSCEngine.sol
/// @audit the ' s_collateralDeposited ' is state variable.
155 s_collateralDeposited[msg.sender][tokenCollateralAddress] += amountCollateral;
https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/blob/main/src/DSCEngine.sol#L155
file: /src/DSCEngine.sol
198 s_DSCMinted[msg.sender] += amountDscToMint;
https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/blob/main/src/DSCEngine.sol#L198
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.