Summary

There is no sense to call _revertIfHealthFactorIsBroken in burnDsc function since it improves health factor it can prevent users to repay in specific situations and waste of gas.

Vulnerability Details

_revertIfHealthFactorIsBroken is called after actions that bring down the health factor while burnDsc improves health factor, in addition to waste of gas it may prevent a user to repay a position .
Consider a scenario that a bad user has minted 100 DSC and is liquidatable , he should burn 20 DSC to be make the position safe but he can only burn 10 DSC , this check won't allow him to burn 10 DSC while it's better to be allowed since it improves health factor and it's for overall health of protocol .

Impact

In aaddition to waste of gas it may prevent improving health factor .

Tools Used

Manual Review

Recommendations

don't call _revertIfHealthFactorIsBroken in burnDSC function .