Relying on Arithmetic Over/Underflow for CollateralToken
Summary
No explicit check used for Collateral Token parameter able to be sent in by external callers to redeemCollateral, redeemCollateralForDsc and liquidate
Vulnerability Details
None but we should be explicit and help make the code more readable instead of relying on the current version of solidity to error when we have an arithmetic over/underflow error
Impact
We should explicitly check for Collateral Tokens, we already have a modifier for this.
Tools Used
Manual Review
Recommendations
Add isAllowedToken modifier to redeemCollateral(), redeemCollateralForUsdc() and liquidate() and use the collateral address parameter as the parameter for the modifier
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.