Submission Details
Severity:
Loss of precision
Summary
Loss of precision
Vulnerability Details
DSCEngine._calculateHealthFactor(uint256,uint256) (src/DSCEngine.sol#324-332) performs a multiplication on the result of a division:
- collateralAdjustedForThreshold = (collateralValueInUsd * LIQUIDATION_THRESHOLD) / LIQUIDATION_PRECISION (src/DSCEngine.sol#330)
- (collateralAdjustedForThreshold * 1e18) / totalDscMinted (src/DSCEngine.sol#331)
Tools Used
slither
Recommendations
I suggest calculating with maximal possible precision.
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
23664 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.