Sparkn

Summary

Missing Zero-Address Check of constructor of L44 of Proxy.sol contract could cause unnecessary errors and imprecision of code execution

Vulnerability Details

Missing zero-address checks for constructor of L44 in the Proxy.sol contract may lead to unwanted errors and accuracy of code execution, which may affect the functions linked to it. For example, assuming the constructor passes in a zero address, all function calls to the Proxy contract will fail because it will delegate the call to a zero-address contract.

Impact

Accidental use of zero-addresses could result in contract malfunction.

Tools Used

Manual review

Recommendations

• reference material：Missing zero-address checks in Curve.transferOwnership and Router.constructor

• E.g.

  error Proxy__NoZeroAddress();

  constructor(address implementation) {

  if(implementation == address(0)) revert Proxy__NoZeroAddress();

  _implementation = implementation;

  }