Sparkn

CodeFox Inc.
DeFiFoundryProxy
15,000 USDC
View results
Submission Details
Severity: low
Valid

A user who is in a token's blacklist will DoS the whole distribution

Summary

A single user can DoS the whole distribution.

Vulnerability Details

Some tokens, such as USDT and USDC, have blacklist mechanisms allowing for admins blocking all transfers towards and from a certain wallet. In the case where one of the winners is within a token's blacklist, the whole transaction will revert and no user will receive any funds.

uint256 winnersLength = winners.length; // cache length
for (uint256 i; i < winnersLength;) {
uint256 amount = totalAmount * percentages[i] / BASIS_POINTS;
erc20.safeTransfer(winners[i], amount);
unchecked {
++i;
}
}

Impact

Distribution will be DoS

Tools Used

Manual review

Recommendations

implement pull-over-push mechanism

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.