Sparkn

Summary

deployProxyAndDistributeBySignature() does not check whether the signature is expired.

The signature should be timestamped, if the signer eventually wants to modify the result of the game, however, other users can preemptively execute the result of the game through this expired signature

Vulnerability Details

https://github.com/Cyfrin/2023-08-sparkn/blob/main/src/ProxyFactory.sol#L152

Impact

The signature should be timestamped, if the signer eventually wants to modify the result of the game, however, other users can preemptively execute the result of the game through this expired signature

Tools Used

manual

Recommendations

Add an expiration time to the signature and check it