Sparkn

Note: Here we are not talking about trusted or untrusted owners, please do not mix it with a Known Issue (M-1 Centralization Risk for trusted owners)

Links

https://github.com/Cyfrin/2023-08-sparkn/blob/main/src/ProxyFactory.sol#L105-L107

https://github.com/Cyfrin/2023-08-sparkn/blob/main/src/ProxyFactory.sol#L179-L184

https://github.com/Cyfrin/2023-08-sparkn/blob/main/src/ProxyFactory.sol#L205-L211

Summary

There are some functions that are strictly dependent on the owner account, such as setContest, deployProxyAndDistributeByOwner and distributeByOwner.

This means lose of this account can break our contract.

• setContest - we will not be able to create new contests

• deployProxyAndDistributeByOwner - In cases where Organizer will not distribute the rewards then owner dependent this function will also not work and funds will stuck.

• distributeByOwner - Nobody can rescue funds if tokens will be stuck after the deployment.

Impact

Our contract will be broken without owner account.

Tools Used

Manual Review

Recommendations

At least use the Multisig wallet for these dependent functions.