Submission Details
Severity:
Missing checks for `address(0)` in function when assigning values to address state variables
Summary
Missing checks for address(0) in function when assigning values to address state variables
Vulnerability Details
Impact
File: src/Distributor.sol
/// @audit token
92: function distribute(address token, address[] memory winners, uint256[] memory percentages, bytes memory data)
93: external
94: {
File: src/Proxy.sol
/// @audit implementation
51: fallback() external {
File: src/ProxyFactory.sol
/// @audit implementation
127: function deployProxyAndDistribute(bytes32 contestId, address implementation, bytes calldata data)
128: public
129: returns (address)
130: {
/// @audit implementation
152: function deployProxyAndDistributeBySignature(
153: address organizer,
154: bytes32 contestId,
155: address implementation,
156: bytes calldata signature,
157: bytes calldata data
158: ) public returns (address) {
/// @audit implementation
179: function deployProxyAndDistributeByOwner(
180: address organizer,
181: bytes32 contestId,
182: address implementation,
183: bytes calldata data
184: ) public onlyOwner returns (address) {
/// @audit implementation
205: function distributeByOwner(
206: address proxy,
207: address organizer,
208: bytes32 contestId,
209: address implementation,
210: bytes calldata data
211: ) public onlyOwner {
/// @audit implementation
239: function _deployProxy(address organizer, bytes32 contestId, address implementation) internal returns (address) {
/// @audit proxy
249: function _distribute(address proxy, bytes calldata data) internal {
127-130, 152-158, 179-184, 205-211, 239, 249
Tools Used
Personal bot
Recommendations
Add address(0) check.
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
19477 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.