Sparkn

Summary

The private variable COMMISSION_FEE is constant but comments mention the intention to change it in the future

Vulnerability Details.

variable that are intended to be changed in the future should not be hardcoded in smart contract or assigned to constant variable.

Impact

Owner is limited as he cannot change the COMMISION_FEE in the future as intended.

Tools Used

Manual review.

Recommendations

Remove the constant keyword and assign a value to COMMISSION_FEE at contract creation or via a function that will update the value of COMMISSION_FEE in the future whenever the owner will want