Sparkn

CodeFox Inc.
DeFiFoundryProxy
15,000 USDC
View results
Submission Details
Severity: low

Use struct to return lots of values

Summary

Function that returns lots of values better off returning struct

Vulnerability Details

Distributor.sol line 186 ...returns (address _FACTORY_ADDRESS, address _STADIUM_ADDRESS, uint256 _COMMISSION_FEE, uint8 _VERSION)

Impact

Cleaner code that is easier to maintain and less likely to introduce errors

Tools Used

Manual Analysis

Recommendations

Can return struct e.g

struct CONSTANTS {address _FACTORY_ADDRESS; address _STADIUM_ADDRESS; uint256 _COMMISSION_FEE; uint8 _VERSION}
....
...returns (CONSTANTS memory)

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.