Inconsistency between in the code comments and the actual implementation.
Misleading Code Comment on Mutability of COMMISSION_FEE
.
The COMMISSION_FEE
variable is declared as a private constant with a value of 500. However, the accompanying code comment indicates that it can be changed in the future.
So there is no way to change this commission fee and it is marked as constant, until a deployment this value won't bulge.
While the code's functionality isn't directly impacted, developers or auditors who rely on comments for understanding might be misled. This can lead to incorrect assumptions about the contract's behavior, especially regarding future modifications or upgrades.
Manuel reviews
Delete this comment or add a function to change the commission fee.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.