Submission Details
Severity:
Hardcoded BASIS_POINTS in distributor contract
Summary
There is a non-zero chance that the commission fee and basis points could undergo decimal point adjustments in the future. Failing to avoid hardcoding the basis points may result in inaccuracies within percentage calculations
Vulnerability Details
if (totalPercentage != (10000 - COMMISSION_FEE)) {
revert Distributor__MismatchedPercentages();
}
Impact
The value of BASIS_POINTS is currently hardcoded as 10000, representing 100% with two decimal places. In the event of adjustments to commission fees involving additional decimals, this rigid coding could lead to inaccuracies in the overall percentage calculation
Tools Used
Manual Review
Recommendations
if (totalPercentage != (BASIS_POINTS - COMMISSION_FEE)) {
revert Distributor__MismatchedPercentages();
}
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
19477 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.